Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 301723003: Disable PPAPITest.FileIO on Win too. (Closed)

Created:
6 years, 7 months ago by msw
Modified:
6 years, 7 months ago
Reviewers:
hidehiko, bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Disable PPAPITest.FileIO on Win too. This test is also highly flaky on Windows (failed 5/7 recent runs). http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29 [3504:128:0527/154657:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. Backtrace: base::debug::StackTrace::StackTrace [0x100A9DC1+33] logging::LogMessage::~LogMessage [0x101495BE+94] base::ThreadRestrictions::AssertIOAllowed [0x102962A6+246] base::File::Close [0x10135082+34] base::File::~File [0x1011551C+60] ... fileapi::FileSystemOperationImpl::DidOpenFile [0x238518A3+179] ... fileapi::`anonymous namespace'::RunCreateOrOpenCallback [0x237F9104+180] ... base::MessageLoop::RunTask [0x10184201+881] ... See full stack in http://crbug.com/378046 BUG=377599, 378046 TBR=hidehiko@chromium.org,bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
The CQ bit was checked by msw@chromium.org
6 years, 7 months ago (2014-05-27 23:29:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/301723003/1
6 years, 7 months ago (2014-05-27 23:31:02 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 03:02:07 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 05:27:45 UTC) #4
Message was sent while issue was closed.
Change committed as 273152

Powered by Google App Engine
This is Rietveld 408576698