Web Notifications should always reappear as popups when updated.

Web Notifications should always reappear as popups when updated.

The message center already does this for notifications with a higher
priority than the notification they replace, but this makes it explicit
for Web Notifications (which cannot indicate priority).

This patch re-enables the NotificationTest.TestNotificationReplacement
test, which was marked as DISABLED because of LSan failures.

BUG=366102, 366539
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286831

[Peter Beverloo, 2014-05-27 14:22:35]

Per issue 366102. I'll run try-jobs to try to reproduce and catch the previous
LSan failure, as we're likely to run into it for the new
NotificationsTest.TestNotificationReplacementReappearance as well.

[dewittj, 2014-06-02 17:30:02]

code lg, also could use a test in notification_list_unittest.cc  -- Thanks!

[Peter Beverloo, 2014-07-28 14:03:52]

On 2014/06/02 17:30:02, dewittj (OOO until August) wrote:
> code lg, also could use a test in notification_list_unittest.cc  -- Thanks!

Done - PTAL

[dewittj, 2014-07-30 23:42:36]

lgtm

https://codereview.chromium.org/301713002/diff/20001/ui/message_center/notifi...
File ui/message_center/notification_list.cc (right):

https://codereview.chromium.org/301713002/diff/20001/ui/message_center/notifi...
ui/message_center/notification_list.cc:106: new_notification->notifier_id().type
== NotifierId::WEB_PAGE) {
nit: This line should be indented 4 spaces

[Peter Beverloo, 2014-07-31 12:55:41]

https://codereview.chromium.org/301713002/diff/20001/ui/message_center/notifi...
File ui/message_center/notification_list.cc (right):

https://codereview.chromium.org/301713002/diff/20001/ui/message_center/notifi...
ui/message_center/notification_list.cc:106: new_notification->notifier_id().type
== NotifierId::WEB_PAGE) {
On 2014/07/30 23:42:36, dewittj wrote:
> nit: This line should be indented 4 spaces

Done.

[Peter Beverloo, 2014-07-31 12:55:44]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-07-31 12:57:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peter@chromium.org/301713002/40001

[commit-bot: I haz the power, 2014-07-31 17:02:11]

Change committed as 286831

[erikchen, 2014-07-31 19:46:16]

A revert of this CL has been created in
https://codereview.chromium.org/417163005/ by erikchen@chromium.org.

The reason for reverting is: Causes Linux ASAN errors.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....