Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 3017055: Merge 54767 - [Mac] M6 Omnibox positioning changes.... (Closed)

Created:
10 years, 4 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 54767 - [Mac] M6 Omnibox positioning changes. 3px from top and bottom of images to cell edges in popup. With this change baselines worked out without tweaking. Omnibox popup text wasn't quite aligned with field because previous change used leading 'w' (regression). This change measured using leading 'P'. Adjust keyword-hint decoration spacing around the image. Also adjust baseline to match font (regression). Modify ImageDecoration to center the image horizontally, which allows the decoration width to be independent of the image width. PageActionDecoration uses this to pin the effective size at |kPageActionIconMaxSize|. Position page-action and bookmark popups so top border is at same gap from Omnibox (2px) as Omnibox popup. The mocks actually show the bookmark point as an additional px from the star "crotch", but I think this is reasonable for M6. BUG=50575, 50765 TEST=none. Everything still works? Review URL: http://codereview.chromium.org/3015046 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -38 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 5 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/cocoa/location_bar/image_decoration.mm View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm View 5 chunks +50 lines, -22 lines 0 comments Download
M chrome/browser/cocoa/location_bar/page_action_decoration.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/location_bar/page_action_decoration.mm View 4 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/location_bar/star_decoration.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Hess - ex-Googler
10 years, 4 months ago (2010-08-03 23:26:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698