| OLD | NEW |
|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 Copyright 2016 The Chromium Authors. All rights reserved. | 3 Copyright 2016 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <link rel="import" href="/tracing/base/timing.html"> | 8 <link rel="import" href="/tracing/base/timing.html"> |
| 9 <link rel="import" href="/tracing/ui/base/name_line_chart.html"> | 9 <link rel="import" href="/tracing/ui/base/name_line_chart.html"> |
| 10 | 10 |
| (...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 248 this.$.overview_container.style.display = 'block'; | 248 this.$.overview_container.style.display = 'block'; |
| 249 this.$.hide_overview.style.display = 'block'; | 249 this.$.hide_overview.style.display = 'block'; |
| 250 this.$.show_overview.style.display = 'none'; | 250 this.$.show_overview.style.display = 'none'; |
| 251 | 251 |
| 252 if (this.overviewChart_ === undefined) { | 252 if (this.overviewChart_ === undefined) { |
| 253 const displayStatisticName = | 253 const displayStatisticName = |
| 254 this.row.rootViewState.displayStatisticName; | 254 this.row.rootViewState.displayStatisticName; |
| 255 const data = []; | 255 const data = []; |
| 256 let unit; | 256 let unit; |
| 257 | 257 |
| 258 for (const [displayLabel, hist] of this.row.columns) { | 258 for (const [displayLabel, hist] of this.row.sortedColumns()) { |
| 259 if (!(hist instanceof tr.v.Histogram)) continue; | 259 if (!(hist instanceof tr.v.Histogram)) continue; |
| 260 | 260 |
| 261 if (unit === undefined) { | 261 if (unit === undefined) { |
| 262 unit = hist.unit; | 262 unit = hist.unit; |
| 263 } else if (unit !== hist.unit) { | 263 } else if (unit !== hist.unit) { |
| 264 // The columns have different units, so the overview chart cannot | 264 // The columns have different units, so the overview chart cannot |
| 265 // use a single unit to format all of the values, so don't display | 265 // use a single unit to format all of the values, so don't display |
| 266 // an overview chart at all. | 266 // an overview chart at all. |
| 267 data.splice(0); | 267 data.splice(0); |
| 268 break; | 268 break; |
| (...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 352 this.$.open_histograms.style.display = mostlyOpen ? 'none' : 'block'; | 352 this.$.open_histograms.style.display = mostlyOpen ? 'none' : 'block'; |
| 353 this.$.close_histograms.style.display = mostlyOpen ? 'block' : 'none'; | 353 this.$.close_histograms.style.display = mostlyOpen ? 'block' : 'none'; |
| 354 } | 354 } |
| 355 }); | 355 }); |
| 356 | 356 |
| 357 return { | 357 return { |
| 358 NAME_COLUMN_WIDTH_PX, | 358 NAME_COLUMN_WIDTH_PX, |
| 359 }; | 359 }; |
| 360 }); | 360 }); |
| 361 </script> | 361 </script> |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 3016683002:
Sort overview chart in histogram-set-table-name-cell. (Closed)
