Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: dashboard/dashboard/elements/trace-button.html

Issue 3016673002: Dashboard - Add pinpoint-perf-job-dialog for perf try jobs.
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/elements/trace-button.html
diff --git a/dashboard/dashboard/elements/trace-button.html b/dashboard/dashboard/elements/trace-button.html
index 3c2e4c439c770a4c481013049c9079ad2beaf95b..a4a2c9b70ac566b54670261c28e64fbf64fd9c01 100644
--- a/dashboard/dashboard/elements/trace-button.html
+++ b/dashboard/dashboard/elements/trace-button.html
@@ -12,7 +12,9 @@ See https://github.com/catapult-project/catapult/issues/1905
<link rel="import" href="/components/paper-button/paper-button.html">
+<link rel="import" href="/dashboard/elements/pinpoint-perf-job-dialog.html">
<link rel="import" href="/dashboard/elements/trace-form.html">
+<link rel="import" href="/dashboard/static/pinpoint.html">
<link rel="import" href="/dashboard/static/simple_xhr.html">
<dom-module id="trace-button">
@@ -45,6 +47,14 @@ See https://github.com/catapult-project/catapult/issues/1905
later-revision="{{traceInfo.badRev}}"
test-path="{{traceInfo.testPath}}"
bug-id="{{bugId}}"></trace-form>
+ <pinpoint-perf-job-dialog
+ id="pinpoint"
+ xsrf-token="{{xsrfToken}}"
+ start-commit="{{traceInfo.goodRev}}"
+ end-commit="{{traceInfo.badRev}}"
sullivan 2017/09/27 19:30:33 These should start working correctly once you use
shatch 2017/09/27 20:41:25 Done.
+ start-repository="{{traceInfo.goodRevRepo}}"
+ end-repository="{{traceInfo.badRevRepo}}"
+ test-path="{{traceInfo.testPath}}"></pinpoint-perf-job-dialog>
</template>
<script>
'use strict';
@@ -64,7 +74,14 @@ See https://github.com/catapult-project/catapult/issues/1905
* Displays the trace-form when the trace button is clicked.
*/
onTrace() {
- this.$.trace.show();
+ const testPathParts = this.traceInfo.testPath.split('/');
+ const botName = testPathParts[1];
+
+ if (d.PINPOINT_BOTS.indexOf(botName) != -1) {
+ this.$.pinpoint.show();
+ } else {
+ this.$.trace.show();
+ }
}
});
})();

Powered by Google App Engine
This is Rietveld 408576698