Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 301663002: Fix toV8 with empty context in InspectorOverlay::overlayPage() (Closed)

Created:
6 years, 7 months ago by tasak
Modified:
6 years, 6 months ago
Reviewers:
haraken, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Fix toV8 with empty context in InspectorOverlay::overlayPage() BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-05-29 04:23:35 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-29 04:24:34 UTC) #2
dgozman
lgtm. Thanks for fixing this
6 years, 6 months ago (2014-05-29 07:01:09 UTC) #3
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-05-29 07:55:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/301663002/1
6 years, 6 months ago (2014-05-29 07:56:01 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 10:32:30 UTC) #6
Message was sent while issue was closed.
Change committed as 175048

Powered by Google App Engine
This is Rietveld 408576698