Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 3016523002: Rename cache_temperature states (Closed)

Created:
3 years, 3 months ago by yukiy
Modified:
3 years, 3 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Rename cache_temperature states This CL renames cache_temperature states, PCV1_COLD to COLD, PCV1_WARM to WARM. PCV1_COLD and PCV1_WARM still exist, but will be removed after some other scripts in chromium/src/tools/perf are adapted to renamed status. BUG=chromium:736697 Review-Url: https://chromiumcodereview.appspot.com/3016523002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c173be04cac21380bd023b948366cbbd55858e3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M telemetry/telemetry/page/cache_temperature.py View 3 chunks +15 lines, -10 lines 0 comments Download
M telemetry/telemetry/page/cache_temperature_unittest.py View 3 chunks +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
yukiy
To implement perf benchmarks for PWA, I want to rename cache_temperature states at first. PTAL
3 years, 3 months ago (2017-09-15 07:14:48 UTC) #2
kouhei (in TOK)
lgtm > are still exists still exist
3 years, 3 months ago (2017-09-15 07:26:39 UTC) #3
nednguyen
lgtm
3 years, 3 months ago (2017-09-15 10:17:05 UTC) #5
nednguyen
On 2017/09/15 10:17:05, nednguyen wrote: > lgtm With this, you will need to do a ...
3 years, 3 months ago (2017-09-15 10:17:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3016523002/1
3 years, 3 months ago (2017-09-19 00:07:59 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-19 00:39:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698