Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 3016463002: Remove unused function - RtcEventLog::ParseRtcEventLog() (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 int bitrate_bps, 137 int bitrate_bps,
138 int min_probes, 138 int min_probes,
139 int min_bytes) = 0; 139 int min_bytes) = 0;
140 140
141 // Logs the result of a successful probing attempt. 141 // Logs the result of a successful probing attempt.
142 virtual void LogProbeResultSuccess(int id, int bitrate_bps) = 0; 142 virtual void LogProbeResultSuccess(int id, int bitrate_bps) = 0;
143 143
144 // Logs the result of an unsuccessful probing attempt. 144 // Logs the result of an unsuccessful probing attempt.
145 virtual void LogProbeResultFailure(int id, 145 virtual void LogProbeResultFailure(int id,
146 ProbeFailureReason failure_reason) = 0; 146 ProbeFailureReason failure_reason) = 0;
147
148 // Reads an RtcEventLog file and returns true when reading was successful.
149 // The result is stored in the given EventStream object.
150 // The order of the events in the EventStream is implementation defined.
151 // The current implementation writes a LOG_START event, then the old
152 // configurations, then the remaining events in timestamp order and finally
153 // a LOG_END event. However, this might change without further notice.
154 // TODO(terelius): Change result type to a vector?
155 static bool ParseRtcEventLog(const std::string& file_name,
156 rtclog::EventStream* result);
157 }; 147 };
158 148
159 // No-op implementation is used if flag is not set, or in tests. 149 // No-op implementation is used if flag is not set, or in tests.
160 class RtcEventLogNullImpl : public RtcEventLog { 150 class RtcEventLogNullImpl : public RtcEventLog {
161 public: 151 public:
162 bool StartLogging(const std::string& file_name, 152 bool StartLogging(const std::string& file_name,
163 int64_t max_size_bytes) override { 153 int64_t max_size_bytes) override {
164 return false; 154 return false;
165 } 155 }
166 bool StartLogging(rtc::PlatformFile platform_file, 156 bool StartLogging(rtc::PlatformFile platform_file,
(...skipping 30 matching lines...) Expand all
197 int min_probes, 187 int min_probes,
198 int min_bytes) override{}; 188 int min_bytes) override{};
199 void LogProbeResultSuccess(int id, int bitrate_bps) override{}; 189 void LogProbeResultSuccess(int id, int bitrate_bps) override{};
200 void LogProbeResultFailure(int id, 190 void LogProbeResultFailure(int id,
201 ProbeFailureReason failure_reason) override{}; 191 ProbeFailureReason failure_reason) override{};
202 }; 192 };
203 193
204 } // namespace webrtc 194 } // namespace webrtc
205 195
206 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 196 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698