Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: runtime/bin/main.cc

Issue 301643003: Fix error message with --observe flag (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index ee2be5fc3971fd061a222474d401d351bc9e015b..13b7938b4174793b6cd00fe9e3b22e63cfe182b8 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -302,13 +302,23 @@ static bool ProcessEnableVmServiceOption(const char* option_value,
return true;
}
+
static bool ProcessObserveOption(const char* option_value,
CommandLineOptions* vm_options) {
ASSERT(option_value != NULL);
- if (!ProcessEnableVmServiceOption(option_value, vm_options)) {
+ if (!ExtractPortAndIP(option_value,
+ &vm_service_server_port,
+ &vm_service_server_ip,
+ DEFAULT_VM_SERVICE_SERVER_PORT,
+ DEFAULT_VM_SERVICE_SERVER_IP)) {
+ Log::PrintErr("unrecognized --observe option syntax. "
+ "Use --observe[:<port number>[/<IPv4 address>]]\n");
return false;
}
+
+ start_vm_service = true;
+
vm_options->AddArgument("--pause-isolates-on-exit");
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698