Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: components/metrics/metrics_log_base_unittest.cc

Issue 301633006: Move ChromeOS hardware class init out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_log_base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log_base_unittest.cc
diff --git a/components/metrics/metrics_log_base_unittest.cc b/components/metrics/metrics_log_base_unittest.cc
index cc7a1737e2a1339a1b8b6f4c0a9c0e1f08fdc19c..4a635bc22aa41cde1090873098d701d8f5760844 100644
--- a/components/metrics/metrics_log_base_unittest.cc
+++ b/components/metrics/metrics_log_base_unittest.cc
@@ -42,7 +42,6 @@ TEST(MetricsLogBaseTest, LogType) {
TEST(MetricsLogBaseTest, EmptyRecord) {
MetricsLogBase log("totally bogus client ID", 137,
MetricsLogBase::ONGOING_LOG, "bogus version");
- log.set_hardware_class("sample-class");
log.CloseLog();
std::string encoded;
@@ -59,8 +58,6 @@ TEST(MetricsLogBaseTest, EmptyRecord) {
expected.mutable_system_profile()->set_build_timestamp(
parsed.system_profile().build_timestamp());
expected.mutable_system_profile()->set_app_version("bogus version");
- expected.mutable_system_profile()->mutable_hardware()->set_hardware_class(
- "sample-class");
EXPECT_EQ(expected.SerializeAsString(), encoded);
}
« no previous file with comments | « components/metrics/metrics_log_base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698