Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 301633006: Move ChromeOS hardware class init out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 832f7a6f7dbf31a7cde3b7807fa645cc1ef8797f..1998bab2204d3d1889cbbda967cbc2e9b3205ead 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/google/google_util.h"
#include "chrome/browser/memory_details.h"
+#include "chrome/browser/metrics/extensions_metrics_provider.h"
#include "chrome/browser/metrics/metrics_service.h"
#include "chrome/browser/ui/browser_otr_state.h"
#include "chrome/common/chrome_constants.h"
@@ -25,6 +26,7 @@
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/crash_keys.h"
#include "chrome/common/render_messages.h"
+#include "content/public/browser/browser_thread.h"
#include "content/public/browser/histogram_fetcher.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_process_host.h"
@@ -33,6 +35,10 @@
#include "chrome/browser/service_process/service_process_control.h"
#endif
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/metrics/chromeos_metrics_provider.h"
+#endif
+
#if defined(OS_WIN)
#include <windows.h>
#include "base/win/registry.h"
@@ -86,7 +92,9 @@ class MetricsMemoryDetails : public MemoryDetails {
ChromeMetricsServiceClient::ChromeMetricsServiceClient(
metrics::MetricsStateManager* state_manager)
- : waiting_for_collect_final_metrics_step_(false),
+ : metrics_state_manager_(state_manager),
+ chromeos_metrics_provider_(NULL),
+ waiting_for_collect_final_metrics_step_(false),
num_async_histogram_fetches_in_progress_(0),
weak_ptr_factory_(this) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -110,11 +118,29 @@ scoped_ptr<ChromeMetricsServiceClient> ChromeMetricsServiceClient::Create(
// receives pointers to fully constructed objects.
scoped_ptr<ChromeMetricsServiceClient> client(
new ChromeMetricsServiceClient(state_manager));
- client->metrics_service_.reset(
- new MetricsService(state_manager, client.get(), local_state));
+ client->Initialize();
+
return client.Pass();
}
+void ChromeMetricsServiceClient::Initialize() {
+ metrics_service_.reset(new MetricsService(
+ metrics_state_manager_, this, g_browser_process->local_state()));
+
+ // Register metrics providers.
+ metrics_service_->RegisterMetricsProvider(
+ scoped_ptr<metrics::MetricsProvider>(
+ new ExtensionsMetricsProvider(metrics_state_manager_)));
+
+#if defined(OS_CHROMEOS)
+ ChromeOSMetricsProvider* chromeos_metrics_provider =
+ new ChromeOSMetricsProvider;
+ chromeos_metrics_provider_ = chromeos_metrics_provider;
+ metrics_service_->RegisterMetricsProvider(
+ scoped_ptr<metrics::MetricsProvider>(chromeos_metrics_provider));
+#endif
+}
+
void ChromeMetricsServiceClient::SetClientID(const std::string& client_id) {
crash_keys::SetClientID(client_id);
}
@@ -311,8 +337,13 @@ void ChromeMetricsServiceClient::Observe(
void ChromeMetricsServiceClient::StartGatheringMetrics(
const base::Closure& done_callback) {
- // TODO(blundell): Move metrics gathering tasks from MetricsService to here.
+// TODO(blundell): Move all metrics gathering tasks from MetricsService to
+// here.
+#if defined(OS_CHROMEOS)
+ chromeos_metrics_provider_->InitTaskGetHardwareClass(done_callback);
+#else
done_callback.Run();
+#endif
}
#if defined(OS_WIN)
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/chromeos_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698