Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/metrics/chromeos_metrics_provider.h

Issue 301633006: Move ChromeOS hardware class init out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chromeos_metrics_provider.h
diff --git a/chrome/browser/metrics/chromeos_metrics_provider.h b/chrome/browser/metrics/chromeos_metrics_provider.h
index 934a3cfca8e79d68955067a7c55c3220500afa0d..c0bc72318c85b612ec35bb64ec2a00bef876a46b 100644
--- a/chrome/browser/metrics/chromeos_metrics_provider.h
+++ b/chrome/browser/metrics/chromeos_metrics_provider.h
@@ -30,6 +30,12 @@ class ChromeOSMetricsProvider : public metrics::MetricsProvider {
// Records a crash.
static void LogCrash(const std::string& crash_type);
+ // Called on the FILE thread to load hardware
+ // class information. When this task is complete, |done_callback| is run on
+ // |target_loop|.
+ void InitTaskGetHardwareClass(base::MessageLoopProxy* target_loop,
+ const base::Closure& callback);
+
// metrics::MetricsProvider:
virtual void OnDidCreateMetricsLog() OVERRIDE;
virtual void ProvideSystemProfileMetrics(
@@ -65,6 +71,11 @@ class ChromeOSMetricsProvider : public metrics::MetricsProvider {
// true.
uint64 user_count_at_log_initialization_;
+ // Chrome OS hardware class (e.g., hardware qualification ID). This
+ // class identifies the configured system components such as CPU,
+ // WiFi adapter, etc.
+ std::string hardware_class_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeOSMetricsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698