Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: chrome/browser/metrics/metrics_services_manager.cc

Issue 301633006: Move ChromeOS hardware class init out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/metrics_services_manager.h" 5 #include "chrome/browser/metrics/metrics_services_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 9 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
10 #include "chrome/browser/metrics/extensions_metrics_provider.h"
11 #include "chrome/browser/metrics/metrics_service.h" 10 #include "chrome/browser/metrics/metrics_service.h"
12 #include "chrome/browser/metrics/metrics_state_manager.h" 11 #include "chrome/browser/metrics/metrics_state_manager.h"
13 #include "chrome/browser/metrics/variations/variations_service.h" 12 #include "chrome/browser/metrics/variations/variations_service.h"
14 #include "chrome/common/chrome_switches.h" 13 #include "chrome/common/chrome_switches.h"
15 #include "chrome/common/pref_names.h" 14 #include "chrome/common/pref_names.h"
16 #include "components/rappor/rappor_service.h" 15 #include "components/rappor/rappor_service.h"
17 16
18 #if defined(OS_CHROMEOS) 17 #if defined(OS_CHROMEOS)
19 #include "chrome/browser/chromeos/settings/cros_settings.h" 18 #include "chrome/browser/chromeos/settings/cros_settings.h"
20 #endif 19 #endif
21 20
22 MetricsServicesManager::MetricsServicesManager(PrefService* local_state) 21 MetricsServicesManager::MetricsServicesManager(PrefService* local_state)
23 : local_state_(local_state) { 22 : local_state_(local_state) {
24 DCHECK(local_state); 23 DCHECK(local_state);
25 } 24 }
26 25
27 MetricsServicesManager::~MetricsServicesManager() { 26 MetricsServicesManager::~MetricsServicesManager() {
28 } 27 }
29 28
30 MetricsService* MetricsServicesManager::GetMetricsService() { 29 MetricsService* MetricsServicesManager::GetMetricsService() {
31 DCHECK(thread_checker_.CalledOnValidThread()); 30 DCHECK(thread_checker_.CalledOnValidThread());
32 if (!metrics_service_client_) { 31 if (!metrics_service_client_) {
33 metrics_service_client_ = 32 metrics_service_client_ =
34 ChromeMetricsServiceClient::Create(GetMetricsStateManager()).Pass(); 33 ChromeMetricsServiceClient::Create(GetMetricsStateManager()).Pass();
35 metrics_service_->RegisterMetricsProvider(
36 scoped_ptr<metrics::MetricsProvider>(
37 new ExtensionsMetricsProvider(GetMetricsStateManager())));
38 } 34 }
39 return metrics_service_client_->metrics_service(); 35 return metrics_service_client_->metrics_service();
40 } 36 }
41 37
42 rappor::RapporService* MetricsServicesManager::GetRapporService() { 38 rappor::RapporService* MetricsServicesManager::GetRapporService() {
43 DCHECK(thread_checker_.CalledOnValidThread()); 39 DCHECK(thread_checker_.CalledOnValidThread());
44 if (!rappor_service_) 40 if (!rappor_service_)
45 rappor_service_.reset(new rappor::RapporService); 41 rappor_service_.reset(new rappor::RapporService);
46 return rappor_service_.get(); 42 return rappor_service_.get();
47 } 43 }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 #if defined(GOOGLE_CHROME_BUILD) 77 #if defined(GOOGLE_CHROME_BUILD)
82 #if defined(OS_CHROMEOS) 78 #if defined(OS_CHROMEOS)
83 chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref, 79 chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
84 &enabled); 80 &enabled);
85 #else 81 #else
86 enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled); 82 enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled);
87 #endif // #if defined(OS_CHROMEOS) 83 #endif // #if defined(OS_CHROMEOS)
88 #endif // defined(GOOGLE_CHROME_BUILD) 84 #endif // defined(GOOGLE_CHROME_BUILD)
89 return enabled; 85 return enabled;
90 } 86 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698