Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 301633003: [fsp] Move unmount unit tests to the operations directory. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[fsp] Move unmount unit tests to the operations directory. Operations are tested outside of the ProvidedFileSystem class. This CL moves the last operation which was tested in the deprecated way. TEST=unit_tests: *FileSystemProviderOperations*Unmount BUG=373165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -233 lines) Patch
A + chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc View 7 chunks +39 lines, -47 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 chunk +0 lines, -185 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
mtomasz
@kinaba: PTAL. This is a mechanical copy&paste. Thanks.
6 years, 7 months ago (2014-05-27 07:46:47 UTC) #1
kinaba
lgtm
6 years, 7 months ago (2014-05-27 07:56:59 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-27 07:57:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/301633003/1
6 years, 7 months ago (2014-05-27 07:57:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 09:40:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 10:53:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/31159)
6 years, 7 months ago (2014-05-27 10:53:43 UTC) #7
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-27 23:22:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/301633003/1
6 years, 7 months ago (2014-05-27 23:23:29 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 00:39:40 UTC) #10
Message was sent while issue was closed.
Change committed as 273091

Powered by Google App Engine
This is Rietveld 408576698