chrome/browser/favicon/favicon_tab_helper.h - Issue 301613004: Turn FaviconClient into a Keyed service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 301613004: Turn FaviconClient into a Keyed service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.h

diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h

index e6a66ad926790819fbea0ad4b0fc49f79be10711..0b54f2aa61de831af4bcf7461907d533d8da758a 100644

--- a/chrome/browser/favicon/favicon_tab_helper.h

+++ b/chrome/browser/favicon/favicon_tab_helper.h

@@ -107,7 +107,7 @@ class FaviconTabHelper : public content::WebContentsObserver,

Profile* profile_;

- scoped_ptr<FaviconClient> client_;

+ FaviconClient* client_;

std::vector<content::FaviconURL> favicon_urls_;