Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 301603002: Fix content_shell under ozone (Closed)

Created:
6 years, 7 months ago by spang
Modified:
6 years, 7 months ago
Reviewers:
sadrul, pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Fix content_shell under ozone We need to call ui::InitializeInputMethodForTesting. This is currently protected by USE_X11 but should not be. TBR=pfeldman BUG=none TEST=content_shell --ozone-platform=egltest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/shell/browser/shell_browser_main_parts.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
spang
6 years, 7 months ago (2014-05-26 17:32:05 UTC) #1
sadrul
lgtm
6 years, 7 months ago (2014-05-26 17:41:54 UTC) #2
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-26 17:48:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/301603002/1
6 years, 7 months ago (2014-05-26 17:48:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 22:02:06 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 00:09:29 UTC) #6
Message was sent while issue was closed.
Change committed as 272895

Powered by Google App Engine
This is Rietveld 408576698