Issue 3016006: Http Cache: Don't delete the callback that is waiting for...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3016006: Http Cache: Don't delete the callback that is waiting for... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by rvargas (out of office)

Modified:
3 years, 11 months ago

Reviewers:
eroman, Paweł Hajdan Jr.

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Http Cache: Don't delete the callback that is waiting for the backend creation when the cache goes away. BUG=49193 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52776

Patch Set 1 #

Total comments: 2

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -2 lines)			Patch
	M	net/http/http_cache.cc	View		2 chunks	+15 lines, -2 lines	0 comments	Download
	M	net/http/http_cache_unittest.cc	View		2 chunks	+32 lines, -0 lines	2 comments	Download

Trybot results: linux mac win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Drive-by with minor test suggestions. http://codereview.chromium.org/3016006/diff/1/3 File net/http/http_cache_unittest.cc (right): http://codereview.chromium.org/3016006/diff/1/3#newcode2007 net/http/http_cache_unittest.cc:2007: delete cache; nit: How ...

4 years, 10 months ago (2010-07-16 21:45:51 UTC) #2

LGTM.

+1 to using scoped_ptr.

Expand Messages | Collapse Messages