Athena unittests framework

Athena unittests framework

BUG=375537
R=abodenha@chromium.org, ben@chromium.org, sadrul@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273378

[Albert Bodenhamer, 2014-05-27 23:13:37]

https://codereview.chromium.org/301593004/diff/170001/athena/test/athena_test...
File athena/test/athena_test_helper.cc (right):

https://codereview.chromium.org/301593004/diff/170001/athena/test/athena_test...
athena/test/athena_test_helper.cc:8: #include "athena/main/placeholder.h"
I'm a bit concerned that we're adding dependencies on placeholder.h even for
tests.

The stuff that placeholder does is sort of an "app". I assume we need this for
the call to SetupBackgroundImage?

Does it make sense for loading an app to be something athena_launcher does?

[oshima, 2014-05-27 23:25:55]

On 2014/05/27 23:13:37, Albert Bodenhamer wrote:
>
https://codereview.chromium.org/301593004/diff/170001/athena/test/athena_test...
> File athena/test/athena_test_helper.cc (right):
> 
>
https://codereview.chromium.org/301593004/diff/170001/athena/test/athena_test...
> athena/test/athena_test_helper.cc:8: #include "athena/main/placeholder.h"
> I'm a bit concerned that we're adding dependencies on placeholder.h even for
> tests.
> 
> The stuff that placeholder does is sort of an "app". I assume we need this for
> the call to SetupBackgroundImage?
> 
> Does it make sense for loading an app to be something athena_launcher does?

placeholder is meant to be go away, so I'm not worrying about it much, but I
moved it to athena_launcher so that when we have a wallpaper manager, it will go
away all together.

I assume TaskManager will provide a way to restore session, and that will
replace the app loading step in current code.

[Albert Bodenhamer, 2014-05-27 23:57:38]

lgtm

[oshima, 2014-05-28 00:16:38]

ben can you approve new athena/test/DEPS file?

[sadrul, 2014-05-28 02:09:28]

lgtm

https://codereview.chromium.org/301593004/diff/200001/athena/athena.gyp
File athena/athena.gyp (right):

https://codereview.chromium.org/301593004/diff/200001/athena/athena.gyp#newco...
athena/athena.gyp:54: 'main/athena_launcher.h',
Perhaps these could move into athena_lib?

[Ben Goodger (Google), 2014-05-28 15:27:33]

lgtm

[oshima, 2014-05-28 18:22:23]

On 2014/05/28 02:09:28, sadrul wrote:
> lgtm
> 
> https://codereview.chromium.org/301593004/diff/200001/athena/athena.gyp
> File athena/athena.gyp (right):
> 
>
https://codereview.chromium.org/301593004/diff/200001/athena/athena.gyp#newco...
> athena/athena.gyp:54: 'main/athena_launcher.h',
> Perhaps these could move into athena_lib?

Probably, but not now. I'll look into it when this is necessary.

[oshima, 2014-05-28 18:22:26]

The CQ bit was checked by oshima@chromium.org

[oshima, 2014-05-28 18:22:30]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2014-05-28 18:23:36]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-28 18:23:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/301593004/200001

[oshima, 2014-05-28 22:36:07]

Committed patchset #3 manually as r273378 (presubmit successful).

[tfarina, 2014-05-29 02:17:16]

https://codereview.chromium.org/301593004/diff/230001/athena/test/athena_unit...
File athena/test/athena_unittests.cc (right):

https://codereview.chromium.org/301593004/diff/230001/athena/test/athena_unit...
athena/test/athena_unittests.cc:32:
ui::ResourceBundle::InitSharedInstanceWithLocale("en-US", NULL);
Do you plan to provide your own pak file?

[tfarina, 2014-09-01 16:47:34]

https://codereview.chromium.org/301593004/diff/230001/athena/test/athena_unit...
File athena/test/athena_unittests.cc (right):

https://codereview.chromium.org/301593004/diff/230001/athena/test/athena_unit...
athena/test/athena_unittests.cc:27: gfx::RegisterPathProvider();
did you need this? if yes, what was the error you get?

It only registers DIR_TEST_DATA.

cs.chromium.org shows you don't call gfx::DIR_TEST_DATA.

https://code.google.com/p/chromium/codesearch#search/&q=gfx::DIR_TEST_DATA&sq...