Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 301553003: Make incremental marker post-process JSWeakCollection. (Closed)

Created:
6 years, 7 months ago by Michael Starzinger
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make incremental marker post-process JSWeakCollection. R=hpayer@chromium.org BUG=v8:2070 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21552

Patch Set 1 #

Patch Set 2 : Drop obsolete function. #

Patch Set 3 : Hide some visitor functions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -74 lines) Patch
M src/heap.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/incremental-marking.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/mark-compact.cc View 2 chunks +1 line, -39 lines 0 comments Download
M src/objects-visiting.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-visiting-inl.h View 4 chunks +36 lines, -7 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 7 months ago (2014-05-26 16:24:32 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 7 months ago (2014-05-27 13:05:16 UTC) #2
Michael Starzinger
6 years, 6 months ago (2014-05-28 08:35:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698