Make unittest_config a dependency of webkit_unit_tests.

Make unittest_config a dependency of webkit_unit_tests.

Prior to this change the webkit_unit_tests target did not enable the plugin for its compilation units.

TBR=eseidel@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174972

[wibling-chromium, 2014-05-27 12:12:45]

lgtm

[haraken, 2014-05-27 12:16:50]

LGTM

[zerny-chromium, 2014-05-27 12:18:37]

+thakis (abarth is OOO)

[Nico, 2014-05-27 13:35:26]

not lgtm, this is wrong. This way, oilpan gets disabled for most of blink, as
far as I know. (One somewhat easy way to check is to run `ninja -t compdb cxx`
and look at the flags for a few blink files.)

I think the right fix is to let unittest_config add this to
direct_dependent_settings too.

[zerny-chromium, 2014-05-27 13:43:30]

On 2014/05/27 13:35:26, Nico (traveling) wrote:
> not lgtm, this is wrong. This way, oilpan gets disabled for most of blink, as
> far as I know. (One somewhat easy way to check is to run `ninja -t compdb cxx`
> and look at the flags for a few blink files.)
> 
> I think the right fix is to let unittest_config add this to
> direct_dependent_settings too.

Thanks for having a look Nico. I'll have a look at getting more test coverage
using compdb. Thanks for the tip!

[zerny-chromium, 2014-05-28 12:30:06]

The unittest_config target already depends on config. However, webkit_unit_tests
does not actually depend on unittest_config. The latest patch set adds that
dependency. PTAL.

[wibling-chromium, 2014-05-28 12:31:34]

lgtm

[Nico, 2014-05-28 12:50:14]

lgtm

[zerny-chromium, 2014-05-28 12:51:46]

+eseidel, could you do an owner review?

[Nico, 2014-05-28 12:52:43]

I think this is simple enough that you can TBR=eseidel.

[zerny-chromium, 2014-05-28 12:55:51]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-05-28 12:56:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zerny@chromium.org/301543005/20001

[commit-bot: I haz the power, 2014-05-28 14:21:27]

Change committed as 174972