Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 301543002: Revert of Remove apk-codegen.xml (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, newt (away)
Visibility:
Public.

Description

Revert of Remove apk-codegen.xml (https://codereview.chromium.org/295473002/) Reason for revert: Suspected for android compile failure on waterfall starting http://build.chromium.org/p/chromium/builders/Android/builds/24321 Errors are pretty obscure. Things like BUILD FAILED /b/build/slave/Android/build/src/build/android/ant/apk-obfuscate.xml:161: /b/build/slave/Android/build/src/out/Release/multiple_proguards_test_apk/proguard.txt (No such file or directory) at proguard.ant.ConfigurationTask.addText(ConfigurationTask.java:315) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) FAILED: cd ../../build/android/tests/multiple_proguards; /*snip*/ build/android/ant/apk-obfuscate.xml Traceback (most recent call last): File "../../../../build/android/gyp/ant.py", line 34, in main stdout = build_utils.CheckOutput(['ant'] + verbose_args) File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py", line 113, in CheckOutput raise CalledProcessError(cwd, args, stdout + stderr) Original issue's description: > Remove apk-codegen.xml > > process_resources.py already implements almost everything from > apk-codegen.xml so just use that instead. > > BUG=359249, 375324, 375431 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272783 TBR=yfriedman@chromium.org,cjhopman@chromium.org NOTREECHECKS=true NOTRY=true BUG=359249, 375324, 375431 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -91 lines) Patch
A build/android/ant/apk-codegen.xml View 1 chunk +98 lines, -0 lines 0 comments Download
M build/android/ant/apk-package-resources.xml View 3 chunks +29 lines, -3 lines 0 comments Download
M build/android/gyp/process_resources.py View 5 chunks +8 lines, -60 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/java.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M build/java_apk.gypi View 3 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Remove apk-codegen.xml
6 years, 7 months ago (2014-05-26 05:09:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/301543002/1
6 years, 7 months ago (2014-05-26 05:09:30 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 05:10:46 UTC) #3
Message was sent while issue was closed.
Change committed as 272795

Powered by Google App Engine
This is Rietveld 408576698