Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301533002: Mojo: Add a GN target for the shell interface. (Closed)

Created:
6 years, 7 months ago by Sam McNally
Modified:
6 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Mojo: Add a GN target for the shell interface. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272881

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M mojo/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/shell/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Sam McNally
6 years, 7 months ago (2014-05-26 00:42:52 UTC) #1
yzshen1
https://codereview.chromium.org/301533002/diff/30001/mojo/public/interfaces/shell/BUILD.gn File mojo/public/interfaces/shell/BUILD.gn (right): https://codereview.chromium.org/301533002/diff/30001/mojo/public/interfaces/shell/BUILD.gn#newcode7 mojo/public/interfaces/shell/BUILD.gn:7: mojom("shell") { Maybe we could call it 'shell_bindings' to ...
6 years, 7 months ago (2014-05-26 06:56:06 UTC) #2
Sam McNally
https://codereview.chromium.org/301533002/diff/30001/mojo/public/interfaces/shell/BUILD.gn File mojo/public/interfaces/shell/BUILD.gn (right): https://codereview.chromium.org/301533002/diff/30001/mojo/public/interfaces/shell/BUILD.gn#newcode7 mojo/public/interfaces/shell/BUILD.gn:7: mojom("shell") { On 2014/05/26 06:56:07, yzshen1 wrote: > Maybe ...
6 years, 7 months ago (2014-05-26 07:02:39 UTC) #3
yzshen1
lgtm
6 years, 7 months ago (2014-05-26 07:12:16 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 7 months ago (2014-05-26 07:12:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/301533002/50001
6 years, 7 months ago (2014-05-26 07:13:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 10:10:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 12:10:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/156941)
6 years, 7 months ago (2014-05-26 12:10:35 UTC) #9
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 7 months ago (2014-05-26 21:13:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/301533002/50001
6 years, 7 months ago (2014-05-26 21:14:44 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 23:43:44 UTC) #12
Message was sent while issue was closed. 
Change committed as 272881

Powered by Google App Engine
This is Rietveld 408576698