Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 301523002: Oilpan: convert remaining dom + page Element refs to transition types. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: convert remaining dom + page Element refs to transition types. R=haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M Source/core/animation/AnimationTimelineTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentMarkerControllerTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-25 16:31:28 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-25 18:10:22 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-25 19:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/301523002/1
6 years, 7 months ago (2014-05-25 19:11:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 20:24:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 20:24:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/7592)
6 years, 7 months ago (2014-05-25 20:24:58 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-25 20:52:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/301523002/1
6 years, 7 months ago (2014-05-25 20:52:18 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-25 20:52:48 UTC) #10
Message was sent while issue was closed.
Change committed as 174775

Powered by Google App Engine
This is Rietveld 408576698