Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp

Issue 3015001: Coverity: fix missing break in GetOIDText, missing commas in ProcessCrlDistPoints output. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
diff --git a/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp b/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
index 4ff155844d7462795ccb0948cd3f1799a8e0b08a..8c5974704865fff98fef6a7d66cba20ed84dc2ac 100644
--- a/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
+++ b/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
@@ -368,6 +368,7 @@ std::string GetOIDText(SECItem* oid) {
break;
case SEC_OID_OCSP_RESPONDER:
string_id = IDS_CERT_EKU_OCSP_SIGNING;
+ break;
case SEC_OID_PKIX_CPS_POINTER_QUALIFIER:
string_id = IDS_CERT_PKIX_CPS_POINTER_QUALIFIER;
break;
@@ -843,6 +844,7 @@ std::string ProcessCrlDistPoints(SECItem* extension_data) {
if (comma)
rv += ',';
rv += l10n_util::GetStringUTF8(reason_string_map[i].string_id);
+ comma = true;
}
}
rv += '\n';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698