Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 301493002: Revert 272635 "cc: Examine layers to determine if we're ready to..." (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272635 "cc: Examine layers to determine if we're ready to..." Caused layout test failures and out-of-memory errors on several Mac bots on the Blink waterfall. See Issue 375206. BUG=375206 > cc: Examine layers to determine if we're ready to activate. > > This introduces a new mechanism for determining when > we're ready to activate the pending tree. The tile > priority is still used to determine when it's worth > waking up the compositor thread and evaluating if > we can activate. However, the actual check that > determines if we're ready to activate doesn't rely > on the state of scheduled raster tasks but is a > synchronous call on each layer. > > The result is a pending tree activation mechanism that > is much easier to debug and validate for correctness, > while still providing the performance benefits of the > old mechanism by taking the "required to activate" field > of the tile priority into account when scheduling tasks. > > BUG=375206 > TEST=cc_unittests --gtest_filter=PictureLayerImplTest.AllTilesRequiredForActivationAreReadyToDraw > > Review URL: https://codereview.chromium.org/287643004 TBR=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -269 lines) Patch
M trunk/src/cc/layers/layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/layers/picture_layer_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/cc/layers/picture_layer_impl.cc View 6 chunks +67 lines, -111 lines 0 comments Download
M trunk/src/cc/layers/picture_layer_impl_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M trunk/src/cc/resources/tile_manager.h View 7 chunks +5 lines, -20 lines 0 comments Download
M trunk/src/cc/resources/tile_manager.cc View 10 chunks +13 lines, -64 lines 0 comments Download
M trunk/src/cc/resources/tile_manager_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/resources/tile_manager_unittest.cc View 5 chunks +40 lines, -5 lines 0 comments Download
M trunk/src/cc/test/fake_tile_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/cc/test/fake_tile_manager.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M trunk/src/cc/test/fake_tile_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-24 00:50:58 UTC) #1
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-24 00:52:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r272660 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698