[pinpoint] Add trace links.

dashboard/dashboard/pinpoint/models/quest/read_value.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
 from dashboard.pinpoint.models.quest import execution
 from dashboard.pinpoint.models.quest import quest
 from dashboard.services import isolate_service
 
@@ skipping 24 matching lines @@
     return _ReadChartJsonValueExecution(self._chart, self._tir_label,
                                         self._trace, isolate_hash)
 
 
 class _ReadChartJsonValueExecution(execution.Execution):
 
   def __init__(self, chart, tir_label, trace, isolate_hash):
     super(_ReadChartJsonValueExecution, self).__init__()
     self._chart = chart
     self._tir_label = tir_label
-    self._trace = trace or 'summary'
+    self._trace = trace
     self._isolate_hash = isolate_hash
 
+    self._trace_url = None
+
   def _AsDict(self):
-    return {}
+    if not self._trace_url:

[shatch, 2017/09/27 11:55:50]

Getting a failure here with no attribute _trace_url on old data. Should include
some migration in this cl.

+      return {}
+    return {'trace_url': self._trace_url}
 
   def _Poll(self):
     chartjson = _RetrieveOutputJson(self._isolate_hash, 'chartjson-output.json')
 
     if self._tir_label:
       chart_name = '@@'.join((self._tir_label, self._chart))
     else:
       chart_name = self._chart
     if chart_name not in chartjson['charts']:
-      raise ReadValueError('The chart "%s" is not in the results.' %
-                           chart_name)
-    if self._trace not in chartjson['charts'][chart_name]:
-      raise ReadValueError('The trace "%s" is not in the results.' %
-                           self._trace)
-    chart = chartjson['charts'][chart_name][self._trace]
+      raise ReadValueError('The chart "%s" is not in the results.' % chart_name)
 
+    trace_name = self._trace or 'summary'
+    if trace_name not in chartjson['charts'][chart_name]:
+      raise ReadValueError('The trace "%s" is not in the results.' % trace_name)
+
+    chart = chartjson['charts'][chart_name][trace_name]
     if chart['type'] == 'list_of_scalar_values':
       result_values = chart['values']
     elif chart['type'] == 'histogram':
       result_values = _ResultValuesFromHistogram(chart['buckets'])
     elif chart['type'] == 'scalar':
       result_values = [chart['value']]
 
+    if self._trace:

[shatch, 2017/09/27 11:55:50]

The bug linked (technically the one duped and closed) is for surfacing all the
trace links for perf try jobs, but this looks like it'll only surface a single
trace link?

[perezju, 2017/09/27 12:24:06]

chartjson (I think) only keeps a link to one of the traces. :(

And, in most cases, since we're using --pageset-repeat 1 this should be OK (I
think).

And this shouldn't be an issue when we move to proper histograms.

+      self._trace_url = chartjson['charts']['trace'][self._trace]['cloud_url']
+
     self._Complete(result_values=tuple(result_values))
 
 
 def _ResultValuesFromHistogram(buckets):
   total_count = sum(bucket['count'] for bucket in buckets)
 
   result_values = []
   for bucket in buckets:
     # TODO: Assumes the bucket is evenly distributed.
     bucket_mean = (bucket['low'] + bucket.get('high', bucket['low'])) / 2
@@ skipping 50 matching lines @@
     self._Complete(result_values=(result_value,))
 
 
 def _RetrieveOutputJson(isolate_hash, filename):
   output_files = isolate_service.Retrieve(isolate_hash)['files']
 
   if filename not in output_files:
     raise ReadValueError("The test didn't produce %s." % filename)
   output_json_isolate_hash = output_files[filename]['h']
   return json.loads(isolate_service.Retrieve(output_json_isolate_hash))