Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3014593002: Use generic functions in zones. (Closed)

Created:
3 years, 3 months ago by terry
Modified:
3 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/dartium-1+
Visibility:
Public.

Description

Use generic functions in zones. Patch from issue 2893893002 at patchset 300001 (http://crrev.com/2893893002#ps300001) Additionally, updated sdk/lib/js/dartium/cached_patches.dart for new html_dartium.dart file. TBR=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/31e9775e001b34b74127a07bae499048496d0894

Patch Set 1 #

Patch Set 2 : Added changes missing from patch set #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -412 lines) Patch
M pkg/compiler/lib/src/common/tasks.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +11 lines, -17 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/async/future.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/async/schedule_microtask.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M sdk/lib/async/timer.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/async/zone.dart View 29 chunks +247 lines, -215 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +11 lines, -17 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +10 lines, -16 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/async/async_await_zones_test.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M tests/lib/async/future_timeout_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/async/run_zoned6_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/lib/async/run_zoned9_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/lib/async/stream_listen_zone_test.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M tests/lib/async/zone_bind_callback_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/lib/async/zone_bind_callback_unary_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/async/zone_debug_test.dart View 5 chunks +10 lines, -8 lines 0 comments Download
M tests/lib/async/zone_error_callback_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M tests/lib/async/zone_fork_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/async/zone_register_callback_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/async/zone_register_callback_unary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/zone_root_bind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/zone_run_guarded_test.dart View 4 chunks +9 lines, -6 lines 0 comments Download
M tests/lib/async/zone_run_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/async/zone_run_unary_test.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/async_await_zones_test.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M tests/lib_strong/async/future_timeout_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib_strong/async/run_zoned6_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/lib_strong/async/run_zoned9_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/lib_strong/async/stream_listen_zone_test.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M tests/lib_strong/async/zone_bind_callback_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_bind_callback_unary_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_debug_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_fork_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib_strong/async/zone_register_callback_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib_strong/async/zone_register_callback_unary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/async/zone_root_bind_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/async/zone_run_guarded_test.dart View 3 chunks +10 lines, -6 lines 0 comments Download
M tests/lib_strong/async/zone_run_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib_strong/async/zone_run_unary_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib_strong/mirrors/invocation_fuzz_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +5 lines, -11 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M utils/compiler/create_snapshot_entry.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
terry
Committed patchset #2 (id:20001) manually as 31e9775e001b34b74127a07bae499048496d0894 (presubmit successful).
3 years, 3 months ago (2017-09-21 12:43:15 UTC) #2
floitsch
3 years, 3 months ago (2017-09-21 17:11:15 UTC) #3
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698