Chromium Code Reviews Chromium Code Reviews
Issue 3014583002:
[pinpoint] Add message in bug when there are no change points. (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 Copyright 2017 The Chromium Authors. All rights reserved. | 3 Copyright 2017 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <link rel="import" href="/dashboard/pinpoint/elements/base-style.html"> | 8 <link rel="import" href="/dashboard/pinpoint/elements/base-style.html"> |
| 9 <link rel="import" href="/dashboard/pinpoint/elements/change-info.html"> | 9 <link rel="import" href="/dashboard/pinpoint/elements/change-info.html"> |
| 10 | 10 |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 31 } | 31 } |
| 32 | 32 |
| 33 td { | 33 td { |
| 34 overflow: scroll; | 34 overflow: scroll; |
| 35 white-space: nowrap; | 35 white-space: nowrap; |
| 36 } | 36 } |
| 37 </style> | 37 </style> |
| 38 | 38 |
| 39 <div class="columns"> | 39 <div class="columns"> |
| 40 <div class="column"> | 40 <div class="column"> |
| 41 <h2>Change points</h2> | 41 <h2>Differences</h2> |
|
perezju
2017/09/21 09:57:18
maybe: Differences found after commits
(shying aw
dtu
2017/09/21 19:32:28
Done.
| |
| 42 <template is="dom-if" if="[[!hasDifferences(job)]]"> | 42 <template is="dom-if" if="[[!hasDifferences(job)]]"> |
| 43 <p>No change points found.</p> | 43 <p>No differences found.</p> |
| 44 </template> | 44 </template> |
| 45 <template is="dom-repeat" items="[[getDifferences(job)]]"> | 45 <template is="dom-repeat" items="[[getDifferences(job)]]"> |
| 46 <change-info change=[[item]]></change-info> | 46 <change-info change=[[item]]></change-info> |
| 47 </template> | 47 </template> |
| 48 </div> | 48 </div> |
| 49 <div class="column"> | 49 <div class="column"> |
| 50 <table> | 50 <table> |
| 51 <template is="dom-repeat" items="[[getArguments(job, 0)]]"> | 51 <template is="dom-repeat" items="[[getArguments(job, 0)]]"> |
| 52 <tr> | 52 <tr> |
| 53 <th>[[item.key]] | 53 <th>[[item.key]] |
| (...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 98 }); | 98 }); |
| 99 | 99 |
| 100 if (rightHalf) { | 100 if (rightHalf) { |
| 101 return tuples.slice(Math.ceil(tuples.length / 2)); | 101 return tuples.slice(Math.ceil(tuples.length / 2)); |
| 102 } | 102 } |
| 103 return tuples.slice(0, Math.ceil(tuples.length / 2)); | 103 return tuples.slice(0, Math.ceil(tuples.length / 2)); |
| 104 } | 104 } |
| 105 }); | 105 }); |
| 106 </script> | 106 </script> |
| 107 </dom-module> | 107 </dom-module> |
| OLD | NEW |
