Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 301433002: Set default for prefs::kGCMChannelEnabled to true on all channels (Closed)

Created:
6 years, 7 months ago by bartfab (slow)
Modified:
6 years, 7 months ago
Reviewers:
jianli
CC:
chromium-reviews
Visibility:
Public.

Description

Set default for prefs::kGCMChannelEnabled to true on all channels GCMProfileService tweaks the default value of prefs::kGCMChannelEnabled so that GCM is enabled by default on the canary/dev/custom channels only. However, the code that uses this pref has been broken for three months now (since http://crrev.com/253787) so that it completely ignores the default pref value. Hence, there is no need to tweak the default. BUG=376746 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/services/gcm/gcm_profile_service.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Jian, Could you take a look please?
6 years, 7 months ago (2014-05-23 12:28:04 UTC) #1
jianli
lgtm
6 years, 7 months ago (2014-05-23 17:14:30 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-23 17:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/301433002/1
6 years, 7 months ago (2014-05-23 17:51:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 21:19:40 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 01:23:30 UTC) #6
Message was sent while issue was closed.
Change committed as 272669

Powered by Google App Engine
This is Rietveld 408576698