Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 301403002: Deprecate the Element.prefix setter (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Deprecate the Element.prefix setter Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Tu9pL7gMPyo/f-eYf_AkpQMJ The conclusion of the thread was to deprecate only at this time. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175202

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M LayoutTests/fast/dom/Element/prefix-setter-exception-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/node-prefix-setter-namespace-exception-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 6 months ago (2014-05-31 06:11:20 UTC) #1
dglazkov
lgtm
6 years, 6 months ago (2014-05-31 15:37:28 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-05-31 18:44:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/301403002/20001
6 years, 6 months ago (2014-05-31 19:00:19 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 20:28:04 UTC) #5
Message was sent while issue was closed.
Change committed as 175202

Powered by Google App Engine
This is Rietveld 408576698