[Mac] Make popup-blocked animation animate to content-setting icon.

[Mac] Make popup-blocked animation animate to content-setting icon.

BUG=none
TEST=www.popuptest.com, click a page to cause popups.  Animation should go to where the blocked-popup content-setting decoration is in the omnibox.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54325

[Scott Hess - ex-Googler, 2010-07-23 00:58:49]

Thinking this might be a good idea, but I'm a little unhappy with how it's wired
together.  Do you know if there are aspects of the blocked-popup animation which
might allow me to make more solid assumptions about the window the TabContents
is in?

[Robert Sesek, 2010-07-23 17:09:31]

I like this a lot. Thanks for doing this (when I attempted it I stuck all the
code in the animation, rather than adding a helper on the LBVM.

On 2010/07/23 00:58:49, shess wrote:
> Thinking this might be a good idea, but I'm a little unhappy with how it's
wired
> together.  Do you know if there are aspects of the blocked-popup animation
which
> might allow me to make more solid assumptions about the window the TabContents
> is in?

Based on the current thread about TabContents on cr-dev, I don't think you can
make any assumptions about the window the contents sits in. This approach looks
good to me, and it was the one I was experimenting with earlier. Since the
notification that kicks off the animation comes from the TabContents, I think
this is the only way.

http://codereview.chromium.org/3014029/diff/1/2
File chrome/browser/cocoa/location_bar/location_bar_view_mac.h (right):

http://codereview.chromium.org/3014029/diff/1/2#newcode121
chrome/browser/cocoa/location_bar/location_bar_view_mac.h:121: NSRect
GetBlockedPopupRect();
() const; ?

http://codereview.chromium.org/3014029/diff/1/4
File chrome/browser/cocoa/popup_blocked_animation_mac.mm (right):

http://codereview.chromium.org/3014029/diff/1/4#newcode133
chrome/browser/cocoa/popup_blocked_animation_mac.mm:133: // Bounce up to the
screen, then back down to the animation
Bounce sounds a little animation-y in this context. Maybe "convert" is better?

[Scott Hess - ex-Googler, 2010-07-30 16:01:48]

http://codereview.chromium.org/3014029/diff/1/2
File chrome/browser/cocoa/location_bar/location_bar_view_mac.h (right):

http://codereview.chromium.org/3014029/diff/1/2#newcode121
chrome/browser/cocoa/location_bar/location_bar_view_mac.h:121: NSRect
GetBlockedPopupRect();
On 2010/07/23 17:09:31, rsesek wrote:
> () const; ?

Done.

http://codereview.chromium.org/3014029/diff/1/4
File chrome/browser/cocoa/popup_blocked_animation_mac.mm (right):

http://codereview.chromium.org/3014029/diff/1/4#newcode133
chrome/browser/cocoa/popup_blocked_animation_mac.mm:133: // Bounce up to the
screen, then back down to the animation
On 2010/07/23 17:09:31, rsesek wrote:
> Bounce sounds a little animation-y in this context. Maybe "convert" is better?

Done.

[Robert Sesek, 2010-07-30 16:05:29]

LGTM. Thanks!