Issue 3014021: [Mac] Use |-performSelector:withDelay:| to execute commands from the Wrench menu.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3014021: [Mac] Use |-performSelector:withDelay:| to execute commands from the Wrench menu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Robert Sesek

Modified:
4 years ago

Reviewers:
Nico, viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Use |-performSelector:withDelay:| to execute commands from the Wrench menu. This avoids doing work from within the menu's nested run loop, which can lead to wonky behavior. BUG=49716 TEST=Enter full screen from Wrench menu a few times. The overlay always appears. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53185

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	chrome/browser/cocoa/wrench_menu_controller.mm	View		2 chunks	+12 lines, -1 line	1 comment	Download

Trybot results:

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

lg http://codereview.chromium.org/3014021/diff/1/2 File chrome/browser/cocoa/wrench_menu_controller.mm (right): http://codereview.chromium.org/3014021/diff/1/2#newcode102 chrome/browser/cocoa/wrench_menu_controller.mm:102: // to wonky behavior. To avoid this, schedule ...

4 years, 10 months ago (2010-07-21 15:15:55 UTC) #3

After-the-fact LG.

Expand Messages | Collapse Messages