Change EXPECT_EQ ordering in CreditCardTest.PreviewSummaryAndObfuscatedNumberString.

I reversed the order of the EXPECT_EQ tests so expected value is first, actual value is second.

BUG=None
TEST=unit_tests --gtest_filter="*CreditCardTest*"

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52961

[dhollowa, 2010-07-19 15:56:25]

http://codereview.chromium.org/3014014/diff/3001/4001
File chrome/browser/autofill/credit_card_unittest.cc (right):

http://codereview.chromium.org/3014014/diff/3001/4001#newcode16
chrome/browser/autofill/credit_card_unittest.cc:16: TEST(CreditCardTest,
FLAKY_PreviewSummaryAndObfuscatedNumberStrings) {
This test fails when .gyp files change on Windows and dependencies are not
correctly resolved.  So this test isn't exactly flakey, but rather a canary for
.gyp changes.

[cbentzel, 2010-07-19 16:35:27]

OK, I'll just close this issue and won't land this CL.

On Mon, Jul 19, 2010 at 11:56 AM, <dhollowa@chromium.org> wrote:

>
> http://codereview.chromium.org/3014014/diff/3001/4001
> File chrome/browser/autofill/credit_card_unittest.cc (right):
>
> http://codereview.chromium.org/3014014/diff/3001/4001#newcode16
> chrome/browser/autofill/credit_card_unittest.cc:16: TEST(CreditCardTest,
> FLAKY_PreviewSummaryAndObfuscatedNumberStrings) {
> This test fails when .gyp files change on Windows and dependencies are
> not correctly resolved.  So this test isn't exactly flakey, but rather a
> canary for .gyp changes.
>
>
> http://codereview.chromium.org/3014014/show
>

[dhollowa, 2010-07-19 17:51:09]

The changes that fix the "expected" parameter ordering are great.  LGTM on
those.


On 2010/07/19 16:35:27, cbentzel wrote:
> OK, I'll just close this issue and won't land this CL.
> 
> On Mon, Jul 19, 2010 at 11:56 AM, <mailto:dhollowa@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/3014014/diff/3001/4001
> > File chrome/browser/autofill/credit_card_unittest.cc (right):
> >
> > http://codereview.chromium.org/3014014/diff/3001/4001#newcode16
> > chrome/browser/autofill/credit_card_unittest.cc:16: TEST(CreditCardTest,
> > FLAKY_PreviewSummaryAndObfuscatedNumberStrings) {
> > This test fails when .gyp files change on Windows and dependencies are
> > not correctly resolved.  So this test isn't exactly flakey, but rather a
> > canary for .gyp changes.
> >
> >
> > http://codereview.chromium.org/3014014/show
> >
>

[cbentzel, 2010-07-19 17:55:09]

Sounds good. I'll update the CL description and land it.

On Mon, Jul 19, 2010 at 1:51 PM, <dhollowa@chromium.org> wrote:

>
> The changes that fix the "expected" parameter ordering are great.  LGTM on
> those.
>
>
>
> On 2010/07/19 16:35:27, cbentzel wrote:
>
>> OK, I'll just close this issue and won't land this CL.
>>
>
>  On Mon, Jul 19, 2010 at 11:56 AM, <mailto:dhollowa@chromium.org> wrote:
>>
>
>  >
>> > http://codereview.chromium.org/3014014/diff/3001/4001
>> > File chrome/browser/autofill/credit_card_unittest.cc (right):
>> >
>> > http://codereview.chromium.org/3014014/diff/3001/4001#newcode16
>> > chrome/browser/autofill/credit_card_unittest.cc:16: TEST(CreditCardTest,
>> > FLAKY_PreviewSummaryAndObfuscatedNumberStrings) {
>> > This test fails when .gyp files change on Windows and dependencies are
>> > not correctly resolved.  So this test isn't exactly flakey, but rather a
>> > canary for .gyp changes.
>> >
>> >
>> > http://codereview.chromium.org/3014014/show
>> >
>>
>
>
>
>
> http://codereview.chromium.org/3014014/show
>