Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: chrome/browser/autofill/credit_card_unittest.cc

Issue 3014014: Change EXPECT_EQ ordering in CreditCardTest.PreviewSummaryAndObfuscatedNumberString. (Closed)
Patch Set: Remove FLAKY prefix. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/credit_card_unittest.cc
diff --git a/chrome/browser/autofill/credit_card_unittest.cc b/chrome/browser/autofill/credit_card_unittest.cc
index f065a9f3a634b822f998bfa2adf2084c14c2416c..5912872fa651f818206cc980e765c5f601af86db 100644
--- a/chrome/browser/autofill/credit_card_unittest.cc
+++ b/chrome/browser/autofill/credit_card_unittest.cc
@@ -16,54 +16,54 @@ TEST(CreditCardTest, PreviewSummaryAndObfuscatedNumberStrings) {
// Case 0: empty credit card.
CreditCard credit_card0(string16(), 0);
string16 summary0 = credit_card0.PreviewSummary();
- EXPECT_EQ(summary0, string16());
+ EXPECT_EQ(string16(), summary0);
string16 obfuscated0 = credit_card0.ObfuscatedNumber();
- EXPECT_EQ(obfuscated0, string16());
+ EXPECT_EQ(string16(), obfuscated0);
// Case 00: Empty credit card with empty strings.
CreditCard credit_card00(string16(), 0);
autofill_unittest::SetCreditCardInfo(&credit_card00, "Corporate",
"John Dillinger", "Visa", "", "", "", "Chicago");
string16 summary00 = credit_card00.PreviewSummary();
- EXPECT_EQ(summary00, string16());
+ EXPECT_EQ(string16(), summary00);
string16 obfuscated00 = credit_card00.ObfuscatedNumber();
- EXPECT_EQ(obfuscated00, string16());
+ EXPECT_EQ(string16(), obfuscated00);
// Case 1: No credit card number.
CreditCard credit_card1(string16(), 0);
autofill_unittest::SetCreditCardInfo(&credit_card1, "Corporate",
"John Dillinger", "Visa", "", "01", "2010", "Chicago");
string16 summary1 = credit_card1.PreviewSummary();
- EXPECT_EQ(summary1, string16());
+ EXPECT_EQ(string16(), summary1);
string16 obfuscated1 = credit_card1.ObfuscatedNumber();
- EXPECT_EQ(obfuscated1, string16());
+ EXPECT_EQ(string16(), obfuscated1);
// Case 2: No month.
CreditCard credit_card2(string16(), 0);
autofill_unittest::SetCreditCardInfo(&credit_card2, "Corporate",
"John Dillinger", "Visa", "123456789012", "", "2010", "Chicago");
string16 summary2 = credit_card2.PreviewSummary();
- EXPECT_EQ(summary2, string16(ASCIIToUTF16("************9012")));
+ EXPECT_EQ(string16(ASCIIToUTF16("************9012")), summary2);
string16 obfuscated2 = credit_card2.ObfuscatedNumber();
- EXPECT_EQ(obfuscated2, string16(ASCIIToUTF16("************9012")));
+ EXPECT_EQ(string16(ASCIIToUTF16("************9012")), obfuscated2);
// Case 3: No year.
CreditCard credit_card3(string16(), 0);
autofill_unittest::SetCreditCardInfo(&credit_card3, "Corporate",
"John Dillinger", "Visa", "123456789012", "01", "", "Chicago");
string16 summary3 = credit_card3.PreviewSummary();
- EXPECT_EQ(summary3, string16(ASCIIToUTF16("************9012")));
+ EXPECT_EQ(string16(ASCIIToUTF16("************9012")), summary3);
string16 obfuscated3 = credit_card3.ObfuscatedNumber();
- EXPECT_EQ(obfuscated3, string16(ASCIIToUTF16("************9012")));
+ EXPECT_EQ(string16(ASCIIToUTF16("************9012")), obfuscated3);
// Case 4: Have everything.
CreditCard credit_card4(string16(), 0);
autofill_unittest::SetCreditCardInfo(&credit_card4, "Corporate",
"John Dillinger", "Visa", "123456789012", "01", "2010", "Chicago");
string16 summary4 = credit_card4.PreviewSummary();
- EXPECT_EQ(summary4, string16(ASCIIToUTF16("************9012, Exp: 01/2010")));
+ EXPECT_EQ(string16(ASCIIToUTF16("************9012, Exp: 01/2010")), summary4);
string16 obfuscated4 = credit_card4.ObfuscatedNumber();
- EXPECT_EQ(obfuscated4, string16(ASCIIToUTF16("************9012")));
+ EXPECT_EQ(string16(ASCIIToUTF16("************9012")), obfuscated4);
}
} // namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698