Issue 3014013: Negotiate on by default on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3014013: Negotiate on by default on all platforms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by cbentzel

Modified:
4 years ago

Reviewers:
ahendrickson

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Negotiate on by default on all platforms. BUG=33033 TEST=Run chrome on POSIX plaforms without explicitly turning on Negotiate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52987

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/io_thread.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Trybot results: mac win linux

Total messages: 2 (0 generated)

cbentzel

This is a much simpler version of enabling Negotiate by default on POSIX. I'll land ...

4 years, 10 months ago (2010-07-17 17:47:29 UTC) #1

LGTM.