Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 3014005: [Mac] Display a quick animation when a popup is blocked so the user notices it in the Omnibox. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: CGImage Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/cocoa/animatable_image.mm ('K') | « chrome/browser/popup_blocked_animation.h ('k') | chrome/browser/views/popup_blocked_animation_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/tab_contents.cc
diff --git a/chrome/browser/tab_contents/tab_contents.cc b/chrome/browser/tab_contents/tab_contents.cc
index b5395ccf89530655321df0903b032a1dd1740d97..8d4d2e4ff748e9d3578fc5297a41e98d3f45b22f 100644
--- a/chrome/browser/tab_contents/tab_contents.cc
+++ b/chrome/browser/tab_contents/tab_contents.cc
@@ -52,6 +52,7 @@
#include "chrome/browser/password_manager/password_manager.h"
#include "chrome/browser/platform_util.h"
#include "chrome/browser/plugin_installer.h"
+#include "chrome/browser/popup_blocked_animation.h"
#include "chrome/browser/pref_service.h"
#include "chrome/browser/printing/print_view_manager.h"
#include "chrome/browser/profile.h"
@@ -946,6 +947,8 @@ void TabContents::PopupNotificationVisibilityChanged(bool visible) {
content_settings_delegate_->SetPopupsBlocked(visible);
if (!dont_notify_render_view_)
render_view_host()->AllowScriptToClose(!visible);
+ if (visible)
+ PopupBlockedAnimation::Show(this);
}
gfx::NativeView TabContents::GetContentNativeView() const {
« chrome/browser/cocoa/animatable_image.mm ('K') | « chrome/browser/popup_blocked_animation.h ('k') | chrome/browser/views/popup_blocked_animation_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698