Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301383003: Eliminate GoogleURLTracker's dependence on //chrome-level switches (Closed)

Created:
6 years, 6 months ago by blundell
Modified:
6 years, 6 months ago
Reviewers:
Nico, Peter Kasting
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jered
Visibility:
Public.

Description

Eliminate GoogleURLTracker's dependence on //chrome-level switches - switches::kGoogleBaseURL is moved into the Google component - The information of whether background networking is enabled is now obtained from GoogleURLTrackerClient. BUG=373222 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274143

Patch Set 1 #

Patch Set 2 : Test fix #

Patch Set 3 : Add google_switches.* #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google/chrome_google_url_tracker_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google/chrome_google_url_tracker_client.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/google/google_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M components/google.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/google/core/browser/google_switches.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + components/google/core/browser/google_switches.cc View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
M components/google/core/browser/google_url_tracker_client.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
blundell
6 years, 6 months ago (2014-05-30 15:09:59 UTC) #1
Peter Kasting
You seem to have forgotten to add the google_switches.* files to this CL. Otherwise, LGTM.
6 years, 6 months ago (2014-05-30 21:44:58 UTC) #2
blundell
derp, files added.
6 years, 6 months ago (2014-05-30 22:00:38 UTC) #3
Peter Kasting
Still fine.
6 years, 6 months ago (2014-05-30 22:02:54 UTC) #4
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-01 14:18:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/301383003/60001
6 years, 6 months ago (2014-06-01 14:19:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-01 16:00:50 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 16:01:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12690)
6 years, 6 months ago (2014-06-01 16:01:01 UTC) #9
blundell
TBR=thakis for //chrome outside of //chrome/browser/google
6 years, 6 months ago (2014-06-01 20:03:38 UTC) #10
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-01 20:03:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/301383003/60001
6 years, 6 months ago (2014-06-01 20:03:58 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 20:10:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 274143

Powered by Google App Engine
This is Rietveld 408576698