[pinpoint] Add a mapping from repository URLs to repository names.

[pinpoint] Add a mapping from repository URLs to repository names.

webrtc just changed repository locations, which means that we have two URLs for
the same repository, the old one and the new one.

If we have an additional mapping from URLs to names, we can have two URL entries
that both map to the same short name. So internally, they will both be known as
'webrtc'. Then when looking up the URL later in the name -> URL mapping, it will
always be the new URL. Essentially, any old URLs get upconverted automatically.

I've chosen to have a separate key with a new name and different structure,
because I want to stress that the original 'repositories' key has the "canonical
repository information" mapping. In case we add other repository information
besides the URL, that's the key to add it to.

If a bisect run finds a DEPS file with an unknown repository URL, it will still
add it automatically to both mappings, similar to before. But if it will have
the same name as another entry, I've chosen to make it fail instead of updating
it. This is to avoid situations where we overwrite a repository name that we
shouldn't. E.g. `src` maps to `breakpad/src`. If someone adds a dep
`other_repo/src`, and we don't want to accidentally overwrite the `src` mapping
to point to `other_repo/src`. We should update the mapping manually in cases
like this.

BUG=catapult:#3861

Review-Url: https://chromiumcodereview.appspot.com/3013683002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bbb2b1f8de98ba6bb904e9f68a08d242d521ec04

[dtu, 2017-09-14 21:49:01]

dtu@chromium.org changed reviewers:
+ perezju@chromium.org, simonhatch@chromium.org, sullivan@chromium.org

[shatch, 2017-09-15 01:14:00]

https://codereview.chromium.org/3013683002/diff/20001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/change/repository.py (right):

https://codereview.chromium.org/3013683002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/repository.py:1: # Copyright 2016 The
Chromium Authors. All rights reserved.
nit year

https://codereview.chromium.org/3013683002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/repository.py:5: from
dashboard.common import namespaced_stored_object
The gitiles handler should also be updated to use this as well.

[dtu, 2017-09-15 06:21:44]

https://codereview.chromium.org/3013683002/diff/20001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/change/repository.py (right):

https://codereview.chromium.org/3013683002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/repository.py:1: # Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/09/15 01:14:00, shatch wrote:
> nit year

Done.

https://codereview.chromium.org/3013683002/diff/20001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/repository.py:5: from
dashboard.common import namespaced_stored_object
On 2017/09/15 01:14:00, shatch wrote:
> The gitiles handler should also be updated to use this as well.

Done.

[shatch, 2017-09-15 11:09:52]

lgtm

[dtu, 2017-09-18 17:01:19]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2017-09-18 17:01:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-18 17:33:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1505754079538800,
"parent_rev": "8a5e45fe0c4635cae0fa99bd75b222376ddd3b9d", "commit_rev":
"bbb2b1f8de98ba6bb904e9f68a08d242d521ec04"}

[commit-bot: I haz the power, 2017-09-18 17:33:59]

Description was changed from

==========
[pinpoint] Add a mapping from repository URLs to repository names.

webrtc just changed repository locations, which means that we have two URLs for
the same repository, the old one and the new one.

If we have an additional mapping from URLs to names, we can have two URL entries
that both map to the same short name. So internally, they will both be known as
'webrtc'. Then when looking up the URL later in the name -> URL mapping, it will
always be the new URL. Essentially, any old URLs get upconverted automatically.

I've chosen to have a separate key with a new name and different structure,
because I want to stress that the original 'repositories' key has the "canonical
repository information" mapping. In case we add other repository information
besides the URL, that's the key to add it to.

If a bisect run finds a DEPS file with an unknown repository URL, it will still
add it automatically to both mappings, similar to before. But if it will have
the same name as another entry, I've chosen to make it fail instead of updating
it. This is to avoid situations where we overwrite a repository name that we
shouldn't. E.g. `src` maps to `breakpad/src`. If someone adds a dep
`other_repo/src`, and we don't want to accidentally overwrite the `src` mapping
to point to `other_repo/src`. We should update the mapping manually in cases
like this.

BUG=catapult:#3861
==========

to

==========
[pinpoint] Add a mapping from repository URLs to repository names.

webrtc just changed repository locations, which means that we have two URLs for
the same repository, the old one and the new one.

If we have an additional mapping from URLs to names, we can have two URL entries
that both map to the same short name. So internally, they will both be known as
'webrtc'. Then when looking up the URL later in the name -> URL mapping, it will
always be the new URL. Essentially, any old URLs get upconverted automatically.

I've chosen to have a separate key with a new name and different structure,
because I want to stress that the original 'repositories' key has the "canonical
repository information" mapping. In case we add other repository information
besides the URL, that's the key to add it to.

If a bisect run finds a DEPS file with an unknown repository URL, it will still
add it automatically to both mappings, similar to before. But if it will have
the same name as another entry, I've chosen to make it fail instead of updating
it. This is to avoid situations where we overwrite a repository name that we
shouldn't. E.g. `src` maps to `breakpad/src`. If someone adds a dep
`other_repo/src`, and we don't want to accidentally overwrite the `src` mapping
to point to `other_repo/src`. We should update the mapping manually in cases
like this.

BUG=catapult:#3861

Review-Url: https://chromiumcodereview.appspot.com/3013683002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-18 17:34:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[perezju, 2017-09-19 11:34:31]

https://codereview.chromium.org/3013683002/diff/40001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/change/repository.py (right):

https://codereview.chromium.org/3013683002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/change/repository.py:12: def
RepositoryUrl(name):
nit: Can you add docstrings to these on a follow up?

Maybe also add some of the explanation you gave on the CL description as
comments here in the code.