Issue 301363002: Web Animations: Avoid leak in AnimationPlayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301363002: Web Animations: Avoid leak in AnimationPlayer (Closed)

Created:
6 years, 6 months ago by dstockwell

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations: Avoid leak in AnimationPlayer AnimationPlayer should stop indicating activity when active dom object is stopped. BUG=379032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175143

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	LayoutTests/LeakExpectations	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/animation/AnimationPlayer.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/301363002/1

6 years, 6 months ago (2014-05-30 10:37:41 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-05-30 14:37:30 UTC) #5

Message was sent while issue was closed.

Change committed as 175143

Expand Messages | Collapse Messages