Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301353011: Add types check to page_set_smoke_test (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add types check to page_set_smoke_test BUG=369703 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M tools/telemetry/telemetry/unittest/page_set_smoke_test.py View 4 chunks +49 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-02 22:51:32 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-02 23:02:43 UTC) #2
tonyg
lgtm love it :)
6 years, 6 months ago (2014-06-03 00:05:02 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-03 00:36:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/301353011/1
6 years, 6 months ago (2014-06-03 00:38:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:04:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 274474

Powered by Google App Engine
This is Rietveld 408576698