Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301353009: Linux: Remove unused gcrypt gyp code. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Linux: Remove unused gcrypt gyp code. BUG=369973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274892

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
D build/linux/libgcrypt-config-wrapper View 1 chunk +0 lines, -17 lines 0 comments Download
M build/linux/system.gyp View 1 2 chunks +0 lines, -25 lines 0 comments Download
M printing/printing.gyp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
Per discussion on the src/printing + GN CL.
6 years, 6 months ago (2014-06-02 21:12:58 UTC) #1
brettw
LGTM!
6 years, 6 months ago (2014-06-02 22:14:26 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-02 22:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/301353009/1
6 years, 6 months ago (2014-06-02 22:29:00 UTC) #4
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 6 months ago (2014-06-03 01:51:20 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-03 01:56:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/301353009/20001
6 years, 6 months ago (2014-06-03 01:58:29 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 05:15:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 07:12:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/20554)
6 years, 6 months ago (2014-06-03 07:12:16 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-04 19:34:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/301353009/20001
6 years, 6 months ago (2014-06-04 19:36:05 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 20:15:32 UTC) #13
Message was sent while issue was closed. 
Change committed as 274892

Powered by Google App Engine
This is Rietveld 408576698