Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issue 301353006: Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS (https://codereview.chromium.org/308083010/) Reason for revert: broke skia/ext/bitmap_platform_device_cairo.cc:44:56: error: no matching function for call to ‘SkBitmap::installPixels Original issue's description: > remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS > > TBR= > NOTRY= > > Committed: http://code.google.com/p/skia/source/detail?r=15007 TBR= NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=15010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
6 years, 6 months ago (2014-05-30 21:01:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/301353006/1
6 years, 6 months ago (2014-05-30 21:03:31 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 21:03:40 UTC) #3
Message was sent while issue was closed.
Change committed as 15010

Powered by Google App Engine
This is Rietveld 408576698