Issue 301353005: Remove hasFallbackContent from RenderEmbeddedObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301353005: Remove hasFallbackContent from RenderEmbeddedObject. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
tkent, dglazkov, eseidel

CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove hasFallbackContent from RenderEmbeddedObject. This belongs on the HTML elements, not on the renderer which is torn down when the fallback content is attached. BUG=379594 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175239

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -14 lines)			Patch
M	Source/core/html/HTMLObjectElement.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/html/HTMLObjectElement.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/core/html/HTMLPlugInElement.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLPlugInElement.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/rendering/RenderEmbeddedObject.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jbroman

This arises from a FIXME left by eseidel in 2010 (during https://bugs.webkit.org/show_bug.cgi?id=45007). This seems easy ...

6 years, 6 months ago (2014-06-02 00:28:17 UTC) #1

eseidel

lgtm I believe this may not have been possible before the untangling of Widget earlier ...

6 years, 6 months ago (2014-06-02 00:30:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/301353005/1

6 years, 6 months ago (2014-06-02 00:31:05 UTC) #3

Message was sent while issue was closed.

Change committed as 175239

Expand Messages | Collapse Messages