url/gurl.cc - Issue 301353003: Using pre-existing constants instead of hard-coding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.cc

Issue 301353003: Using pre-existing constants instead of hard-coding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/gurl.cc

diff --git a/url/gurl.cc b/url/gurl.cc

index c79cdba1aa21902651a6868579a4be7e0f326753..947403e19705598e9ef32cc67ea609ab21584c28 100644

--- a/url/gurl.cc

+++ b/url/gurl.cc

@@ -370,11 +370,11 @@ bool GURL::SchemeIs(const char* lower_ascii_scheme) const {

}

bool GURL::SchemeIsHTTPOrHTTPS() const {

- return SchemeIs("http") || SchemeIs("https");

+ return SchemeIs(url::kHttpScheme) || SchemeIs(url::kHttpsScheme);

}

bool GURL::SchemeIsWSOrWSS() const {

- return SchemeIs("ws") || SchemeIs("wss");

+ return SchemeIs(url::kWsScheme) || SchemeIs(url::kWssScheme);

}

int GURL::IntPort() const {

« url/gurl.h ('K') | « url/gurl.h ('k') | url/url_constants.h » ('j') | no next file with comments »