Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 301353003: Using pre-existing constants instead of hard-coding (Closed)

Created:
6 years, 6 months ago by amogh.bihani
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Using pre-existing constants instead of hard-coding Constants for https, http already exists in our_constants. This patch makes gurl use those constants instead of hrad-coded values. Also it adds constants for WS and WSS. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274179

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Removing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M url/gurl.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M url/gurl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M url/url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
amogh.bihani
PTAL. This is more of a clean-up thing. The 'https' and 'wss' were initilally written ...
6 years, 6 months ago (2014-05-30 12:49:14 UTC) #1
brettw
lgtm https://codereview.chromium.org/301353003/diff/20001/url/gurl.h File url/gurl.h (right): https://codereview.chromium.org/301353003/diff/20001/url/gurl.h#newcode235 url/gurl.h:235: return SchemeIs(url::kHttpsScheme) || SchemeIs(kWssScheme) || need url:: on ...
6 years, 6 months ago (2014-05-30 17:36:28 UTC) #2
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-02 03:38:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/301353003/40001
6 years, 6 months ago (2014-06-02 03:38:57 UTC) #4
amogh.bihani
The CQ bit was unchecked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-02 03:39:59 UTC) #5
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 6 months ago (2014-06-02 05:48:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/301353003/40001
6 years, 6 months ago (2014-06-02 05:51:03 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 06:20:37 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 07:34:38 UTC) #9
Message was sent while issue was closed.
Change committed as 274179

Powered by Google App Engine
This is Rietveld 408576698