chrome/browser/resources/options/autofill_options.js - Issue 301343002: mac: Clean up autofill integration with Address Book.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/autofill_options.js

Issue 301343002: mac: Clean up autofill integration with Address Book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autofill_cleanup2_base

Patch Set: Autofill test failures on Android. Undo a change to autofill_test_utils.cc. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/autofill_options.html ('k') | chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/autofill_options.js

diff --git a/chrome/browser/resources/options/autofill_options.js b/chrome/browser/resources/options/autofill_options.js

index 65fb71964ae3b36009ec69e61533028ee7926a55..bc4c90cf7036f97ea56085d23c1f6fab26f6170e 100644

--- a/chrome/browser/resources/options/autofill_options.js

+++ b/chrome/browser/resources/options/autofill_options.js

@@ -55,6 +55,19 @@ cr.define('options', function() {

$('autofill-options-confirm').onclick = function(event) {

OptionsPage.closeOverlay();

};

+<if expr="is_macosx">

+ $('autofill-use-mac-address-book-checkbox').onchange = function(event) {

+ if (this.checked) {

+ setTimeout(function() {

+ // Prompt the user to give Chrome access to the user's Address

+ // Book, if the user was not previously prompted. The dialog that

+ // appears blocks the Chrome process, so wait for a small period of

+ // time to allow the checkbox to appear filled in.

+ chrome.send('accessAddressBook');

+ }, 10);

+ }

+ };

+</if>

// TODO(jhawkins): What happens when Autofill is disabled whilst on the

// Autofill options page?