mac: Clean up autofill integration with Address Book.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 916791252a78aab5aef79c2dac1a06fdd6ef2d5f..3eb4ee5c2717a70be91310451ab17b94b72f5d06 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -1610,6 +1610,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <summary>Tracks whether Autofill is enabled when Chrome launches.</summary>
 </histogram>
 
+<histogram name="AutoFill.MacAddressBook" enum="AutofillMacAddressBook">

[Ilya Sherman, 2014/06/04 21:24:47]

nit: "AutoFill" -> "Autofill"

[erikchen, 2014/06/04 22:11:12]

Good catch.

+  <owner>erikchen@chromium.org</owner>
+  <summary>
+    Tracks whether users select the unique to Mac Autofill entry that prompts
+    them to give Chrome access to their Address Book.

[Ilya Sherman, 2014/06/04 21:24:47]

I'd suggest rewording this to clarify what is being measured for someone who's
not very familiar with the Autofill feature.  Specifically, I'd mention the OS's
blocking dialog, and mention that this entry appears in the Autofill popup, and
that it only appears when there are no other suggestions.

[erikchen, 2014/06/04 22:11:12]

I've rewritten and expanded the summary.

+  </summary>
+</histogram>
+
 <histogram name="AutoFill.ProfileCount">
   <obsolete>
     Deprecated as of 3/2011, replaced by Autofill.StoredProfileCount.
@@ -32269,6 +32277,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="17" label="fp05cc03e1"/>
 </enum>
 
+<enum name="AutofillMacAddressBook" type="int">
+  <int value="0" label="Showed Autofill entry"/>
+  <int value="1" label="Selected Autofill entry"/>

[Ilya Sherman, 2014/06/04 21:24:47]

Optional nit: I'd suggest replacing "Autofill" with "popup"

[erikchen, 2014/06/04 22:11:12]

Done

+</enum>
+
 <enum name="AutofillQuality" type="int">
   <int value="0" label="Submitted"/>
   <int value="1" label="Autofilled"/>