mac: Clean up autofill integration with Address Book.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 185 matching lines @@
 
 // static
 void AutofillManager::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(
       prefs::kAutofillEnabled,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
   registry->RegisterBooleanPref(
-      prefs::kAutofillAuxiliaryProfilesEnabled,
+      prefs::kAutofillAndroidAuxiliaryProfilesEnabled,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 #else  // defined(OS_MACOSX) || defined(OS_ANDROID)
   registry->RegisterBooleanPref(
-      prefs::kAutofillAuxiliaryProfilesEnabled,
+      prefs::kAutofillAndroidAuxiliaryProfilesEnabled,
       false,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 #endif  // defined(OS_MACOSX) || defined(OS_ANDROID)
 #if defined(OS_MACOSX)
   registry->RegisterBooleanPref(
-      prefs::kAutofillAuxiliaryProfilesQueried,
+      prefs::kAutofillMacAddressBookQueried,
       false,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 #endif  // defined(OS_MACOSX)
   registry->RegisterDoublePref(
       prefs::kAutofillPositiveUploadRate,
       kAutofillPositiveUploadRateDefaultValue,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
       prefs::kAutofillNegativeUploadRate,
       kAutofillNegativeUploadRateDefaultValue,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+  registry->RegisterBooleanPref(
+      prefs::kAutofillUseMacAddressBook,
+      false,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterBooleanPref(
+      prefs::kAutofillHasMigratedUseMacAddressBookPref,
+      false,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+#endif
 }
 
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+void AutofillManager::MigrateUserPrefs(PrefService* prefs) {
+  if (prefs->GetBoolean(prefs::kAutofillHasMigratedUseMacAddressBookPref))

[Ilya Sherman, 2014/06/03 23:48:59]

It looks like the PrefService exports a method named IsDefaultValue().  Can we
use that method to eliminate this extra pref entirely?

[erikchen, 2014/06/04 01:51:25]

Yes. I've done so.

+    return;
+
+  // Whether Chrome has already tried to access the user's Address Book.
+  bool accessed = prefs->GetBoolean(prefs::kAutofillMacAddressBookQueried);
+  // Whether the user wants to use the Address Book to populate Autofill.
+  bool enabled =
+      prefs->GetBoolean(prefs::kAutofillAndroidAuxiliaryProfilesEnabled);

[Ilya Sherman, 2014/06/03 23:48:59]

Hmm, this looks really odd.  It makes me think that I was wrong to suggest just
changing the pref name in code -- we should either revert to the previous name,
or actually migrate from the old pref to a new pref that's defined just on
Android.

[erikchen, 2014/06/04 01:51:25]

I reverted to the previous name.

+
+  prefs->SetBoolean(prefs::kAutofillUseMacAddressBook, accessed && enabled);
+  prefs->SetBoolean(prefs::kAutofillHasMigratedUseMacAddressBookPref, true);
+}
+#endif
+
 void AutofillManager::SetExternalDelegate(AutofillExternalDelegate* delegate) {
   // TODO(jrg): consider passing delegate into the ctor.  That won't
   // work if the delegate has a pointer to the AutofillManager, but
   // future directions may not need such a pointer.
   external_delegate_ = delegate;
   autocomplete_history_manager_->SetExternalDelegate(delegate);
 }
 
 void AutofillManager::ShowAutofillSettings() {
   manager_delegate_->ShowAutofillSettings();
@@ skipping 919 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed(true))
     return false;
 
   return true;
 }
 
 }  // namespace autofill