Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 301323003: Remove GaiaAuthFetcher::StartCookieForOAuthCodeExchange. (Closed)

Created:
6 years, 6 months ago by pavely
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove GaiaAuthFetcher::StartCookieForOAuthCodeExchange. It is not used anywhere. R=rogerta@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -85 lines) Patch
M google_apis/gaia/gaia_auth_consumer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 2 chunks +0 lines, -12 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 4 chunks +3 lines, -18 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 3 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pavely
6 years, 6 months ago (2014-05-29 22:48:27 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Thanks for cleanup Pavel!
6 years, 6 months ago (2014-05-30 15:01:42 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 6 months ago (2014-05-30 15:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/301323003/1
6 years, 6 months ago (2014-05-30 15:47:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 21:16:23 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:02:16 UTC) #6
Message was sent while issue was closed.
Change committed as 273968

Powered by Google App Engine
This is Rietveld 408576698