Issue 3013048: Convert src/net to use std::string/char* for DictionaryValue keys.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3013048: Convert src/net to use std::string/char* for DictionaryValue keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by viettrungluu

Modified:
3 years, 11 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Convert src/net to use std::string/char* for DictionaryValue keys. Hopefully I got them all. BUG=23581 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54433

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -39 lines)			Patch
M	net/base/address_list_net_log_param.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/host_resolver_impl.cc	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	net/base/net_log.cc	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	net/base/transport_security_state.cc	View		4 chunks	+12 lines, -12 lines	0 comments	Download
M	net/http/http_net_log_params.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_resolver_js_bindings.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	net/url_request/url_request_netlog_params.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Trybot results: linux win mac

Total messages: 1 (0 generated)

LGTM