Chromium Code Reviews
Help | Chromium Project | Sign in
(319)

Issue 3013048: Convert src/net to use std::string/char* for DictionaryValue keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by viettrungluu
Modified:
3 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Convert src/net to use std::string/char* for DictionaryValue keys. Hopefully I got them all. BUG=23581 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54433

Patch Set 1 #

Patch Set 2 : fix for windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M net/base/address_list_net_log_param.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver_impl.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M net/base/net_log.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/base/transport_security_state.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M net/http/http_net_log_params.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_resolver_js_bindings.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_netlog_params.cc View 1 chunk +4 lines, -4 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 1 (0 generated)
Lei Zhang
4 years, 10 months ago (2010-07-31 05:25:50 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be